Page MenuHomePhabricator
Differential D17109

Restore "Plan Changes" and "Request Review" actions to Differential on EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 28 2016, 9:42 PM.
Tags
None
Referenced Files
F13242484: D17109.diff
Thu, May 23, 2:48 AM
F13192615: D17109.diff
Sun, May 12, 9:03 AM
F13173853: D17109.diff
Tue, May 7, 9:12 PM
Unknown Object (File)
Mon, Apr 29, 8:27 AM
Unknown Object (File)
Apr 19 2024, 5:58 PM
Unknown Object (File)
Apr 5 2024, 3:38 PM
Unknown Object (File)
Apr 3 2024, 4:06 PM
Unknown Object (File)
Mar 30 2024, 3:43 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rPdeb19b2d572d: Restore "Plan Changes" and "Request Review" actions to Differential on…
Summary

Ref T11114. This restores these actions.

One behavior is incomplete: "Request Review" on an accepted revision does not downgrade reviewers properly. I've noted this locally.

Test Plan

Planned changes and requested review of a revision.

Diff Detail

Repository
rP Phabricator
Branch
haunt5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15035
Build 19727: Run Core Tests
Build 19726: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 28 2016, 9:42 PM
chad accepted this revision.Dec 29 2016, 5:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:59 PM
Closed by commit rPdeb19b2d572d: Restore "Plan Changes" and "Request Review" actions to Differential on… (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2016, 6:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41148

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php

Loading...
Phabricator · Built by Phacility