Page MenuHomePhabricator
Differential D17079

Remove "Reviewed By" Differential field
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 5:12 PM.
Tags
None
Referenced Files
F13227265: D17079.id41071.diff
Mon, May 20, 2:13 AM
F13216351: D17079.id41095.diff
Sat, May 18, 12:17 AM
F13213403: D17079.diff
Fri, May 17, 7:43 AM
F13193692: D17079.diff
Sun, May 12, 4:58 PM
Unknown Object (File)
Tue, May 7, 6:38 AM
Unknown Object (File)
Fri, May 3, 2:09 AM
Unknown Object (File)
Fri, May 3, 1:31 AM
Unknown Object (File)
Mon, Apr 29, 4:27 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP77601bf58c9a: Remove "Reviewed By" Differential field
Summary

Ref T11114. This is replaced by DifferentialReviewedByCommitMessageField.php.

Test Plan
  • Used differential.getcommitmessage to query an accepted revision, saw "Reviewed By".
  • Grepped for removed class name.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 41071.Dec 16 2016, 5:12 PM
epriestley retitled this revision from to Remove "Reviewed By" Differential field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
chad accepted this revision.Dec 16 2016, 5:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 5:21 PM
Closed by commit rP77601bf58c9a: Remove "Reviewed By" Differential field (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 6:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
config/
1 line
customfield/

Diff 41095

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...
View Options

src/applications/differential/customfield/DifferentialReviewedByField.php

Loading...
Phabricator · Built by Phacility