Page MenuHomePhabricator
Differential D17079

Remove "Reviewed By" Differential field
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 4:27 PM
Unknown Object (File)
Thu, Apr 25, 12:07 AM
Unknown Object (File)
Mon, Apr 22, 11:25 PM
Unknown Object (File)
Fri, Apr 19, 5:55 PM
Unknown Object (File)
Thu, Apr 11, 8:23 AM
Unknown Object (File)
Apr 2 2024, 12:10 PM
Unknown Object (File)
Mar 30 2024, 3:36 AM
Unknown Object (File)
Mar 29 2024, 1:58 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP77601bf58c9a: Remove "Reviewed By" Differential field
Summary

Ref T11114. This is replaced by DifferentialReviewedByCommitMessageField.php.

Test Plan
  • Used differential.getcommitmessage to query an accepted revision, saw "Reviewed By".
  • Grepped for removed class name.

Diff Detail

Repository
rP Phabricator
Branch
diff31
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14960
Build 19616: Run Core Tests
Build 19615: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41071.Dec 16 2016, 5:12 PM
epriestley retitled this revision from to Remove "Reviewed By" Differential field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
chad accepted this revision.Dec 16 2016, 5:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 5:21 PM
Closed by commit rP77601bf58c9a: Remove "Reviewed By" Differential field (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 6:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
config/
1 line
customfield/

Diff 41071

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...
View Options

src/applications/differential/customfield/DifferentialReviewedByField.php

Loading...
Phabricator · Built by Phacility