Remove unusual explicit calls to policy capability descriptions from Diviner
ClosedPublic
Actions

Authored by epriestley on Dec 14 2016, 7:04 PM.

Details

Reviewers

avivey
chad

Maniphest Tasks

T12015: Unable to resolve method 'describeAutomaticCapability'.

Commits

rPae0e97a49974: Remove unusual explicit calls to policy capability descriptions from Diviner

Summary

Fixes T12015. This is weird and probably got copy/pasted from something else that was also being weird, since the methods were empty and I previously removed them.

Test Plan

Edited a book in Diviner.

Diff Detail

Repository

rP Phabricator

Branch

bookedit

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14915
Build 19539: Run Core Tests
Build 19538: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41027.Dec 14 2016, 7:04 PM

epriestley retitled this revision from to Remove unusual explicit calls to policy capability descriptions from Diviner.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T12015: Unable to resolve method 'describeAutomaticCapability'..

avivey accepted this revision.Dec 14 2016, 7:05 PM

avivey added a reviewer: avivey.

This revision is now accepted and ready to land.Dec 14 2016, 7:05 PM

Closed by commit rPae0e97a49974: Remove unusual explicit calls to policy capability descriptions from Diviner (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2016, 7:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

controller/

DivinerBookEditController.php

6 lines

Diff 41027

View Options

src/applications/diviner/controller/DivinerBookEditController.php

Remove unusual explicit calls to policy capability descriptions from DivinerClosedPublicActions