Page MenuHomePhabricator
Differential D17056

Remove unusual explicit calls to policy capability descriptions from Diviner
ClosedPublic
Actions

Authored by epriestley on Dec 14 2016, 7:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 23, 3:32 PM
Unknown Object (File)
Tue, Jul 23, 3:22 PM
Unknown Object (File)
Tue, Jul 23, 3:14 PM
Unknown Object (File)
Tue, Jul 23, 2:41 PM
Unknown Object (File)
Sun, Jul 21, 9:56 AM
Unknown Object (File)
Wed, Jul 17, 10:38 AM
Unknown Object (File)
Tue, Jul 16, 6:43 AM
Unknown Object (File)
Mon, Jul 15, 4:06 PM
View All Files
Subscribers
None

Details

Reviewers
avivey
chad
Maniphest Tasks
T12015: Unable to resolve method 'describeAutomaticCapability'.
Commits
rPae0e97a49974: Remove unusual explicit calls to policy capability descriptions from Diviner
Summary

Fixes T12015. This is weird and probably got copy/pasted from something else that was also being weird, since the methods were empty and I previously removed them.

Test Plan

Edited a book in Diviner.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 41027.Dec 14 2016, 7:04 PM
epriestley retitled this revision from to Remove unusual explicit calls to policy capability descriptions from Diviner.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T12015: Unable to resolve method 'describeAutomaticCapability'..
avivey accepted this revision.Dec 14 2016, 7:05 PM
avivey added a reviewer: avivey.
This revision is now accepted and ready to land.Dec 14 2016, 7:05 PM
Closed by commit rPae0e97a49974: Remove unusual explicit calls to policy capability descriptions from Diviner (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2016, 7:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
controller/
6 lines

Diff 41028

View Options

src/applications/diviner/controller/DivinerBookEditController.php

Loading...
Phabricator · Built by Phacility