Page MenuHomePhabricator
Differential D17024

Fix two cache issues (global settings; initial setup)
ClosedPublic
Actions

Authored by epriestley on Dec 11 2016, 3:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 5:29 PM
Unknown Object (File)
Thu, Apr 25, 2:04 AM
Unknown Object (File)
Wed, Apr 24, 10:49 AM
Unknown Object (File)
Fri, Apr 12, 10:23 PM
Unknown Object (File)
Thu, Apr 11, 9:37 AM
Unknown Object (File)
Mar 27 2024, 12:27 PM
Unknown Object (File)
Mar 26 2024, 7:19 PM
Unknown Object (File)
Mar 26 2024, 2:27 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11993: New install errors out before "run storage upgrade" message
T11995: Fatal error while saving global default preferences
Commits
rP3cd0001d8b95: (stable) Fix two cache issues (global settings; initial setup)
rPf3d9a0b93000: Fix two cache issues (global settings; initial setup)
Summary
  • Fixes T11995. This got moved but I missed renaming this callsite.
  • Fixes T11993. If you have valid credentials, but haven't run storage upgrade yet, we can hit this exception during setup. Just ignore it instead.
Test Plan
  • Saved global settings, no more fatal.
  • Changed storage-namespace to junk, loaded web UI with valid database credentials.

Screen Shot 2016-12-11 at 7.15.09 AM.png (989×1 px, 79 KB)

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14839
Build 19419: Run Core Tests
Build 19418: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40951.Dec 11 2016, 3:17 PM
epriestley retitled this revision from to Fix two cache issues (global settings; initial setup).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T11995: Fatal error while saving global default preferences, T11993: New install errors out before "run storage upgrade" message.
chad accepted this revision.Dec 11 2016, 3:29 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2016, 3:29 PM
Closed by commit rPf3d9a0b93000: Fix two cache issues (global settings; initial setup) (authored by epriestley, committed by epriestley). · Explain WhyDec 11 2016, 4:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
8 lines
settings/
editor/
2 lines

Diff 40951

View Options

src/applications/config/check/PhabricatorSetupCheck.php

Loading...
View Options

src/applications/settings/editor/PhabricatorUserPreferencesEditor.php

Loading...
Phabricator · Built by Phacility