Paths

Table of Contentst

Differential D17012

Tokenize datasource indexes on "(" and ")"
ClosedPublic
Actions

Authored by epriestley on Dec 9 2016, 1:34 PM.

Details

Reviewers

chad

Maniphest Tasks

T11955: Tag autocomplete doesn't always include milestones

Commits

rP5a95efaa4b77: Tokenize datasource indexes on "(" and ")"

Summary

Fixes T11955. Milestone names are currently tokenizing and indexing awkwardly. For example, "A (B C D)" becomes the tokens "A", "(B", "C" and "D)".

The token "(B" can't be searched for since "(" is tokenized on the client.

Instead, tokenize "A (B C D)" into "A", "B", "C", "D".

Test Plan

Added unit tests.
Used bin/search index --type project --force to reindex.
Searched for "A", "B", "C", "D", etc., for real examples.
Now, found milestones more consistently.
Also serached for viewer(), members(), etc.

Diff Detail

Repository

rP Phabricator

Branch

milestone1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14818
Build 19386: Run Core Tests
Build 19385: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40930.Dec 9 2016, 1:34 PM

epriestley retitled this revision from to Tokenize datasource indexes on "(" and ")".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11955: Tag autocomplete doesn't always include milestones.

epriestley mentioned this in T11955: Tag autocomplete doesn't always include milestones.Dec 9 2016, 1:36 PM

Bonus test case.

chad accepted this revision.Dec 9 2016, 3:53 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2016, 3:53 PM

Closed by commit rP5a95efaa4b77: Tokenize datasource indexes on "(" and ")" (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2016, 4:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

typeahead/

datasource/

PhabricatorTypeaheadDatasource.php

4 lines

__tests__/

PhabricatorTypeaheadDatasourceTestCase.php

12 lines

Diff 40931

View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

View Options

src/applications/typeahead/datasource/tests/PhabricatorTypeaheadDatasourceTestCase.php

Tokenize datasource indexes on "(" and ")"ClosedPublicActions