Page MenuHomePhabricator
Differential D17012

Tokenize datasource indexes on "(" and ")"
ClosedPublic
Actions

Authored by epriestley on Dec 9 2016, 1:34 PM.
Tags
None
Referenced Files
F15447031: D17012.id40935.diff
Thu, Mar 27, 9:30 PM
F15442779: D17012.id40931.diff
Thu, Mar 27, 12:23 AM
F15440584: D17012.id40930.diff
Wed, Mar 26, 1:39 PM
F15440261: D17012.id.diff
Wed, Mar 26, 11:44 AM
F15437294: D17012.diff
Tue, Mar 25, 6:47 PM
F15417214: D17012.id40931.diff
Thu, Mar 20, 4:03 PM
F15407423: D17012.id.diff
Tue, Mar 18, 5:28 PM
F15393105: D17012.diff
Sat, Mar 15, 7:42 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11955: Tag autocomplete doesn't always include milestones
Commits
rP5a95efaa4b77: Tokenize datasource indexes on "(" and ")"
Summary

Fixes T11955. Milestone names are currently tokenizing and indexing awkwardly. For example, "A (B C D)" becomes the tokens "A", "(B", "C" and "D)".

The token "(B" can't be searched for since "(" is tokenized on the client.

Instead, tokenize "A (B C D)" into "A", "B", "C", "D".

Test Plan
  • Added unit tests.
  • Used bin/search index --type project --force to reindex.
  • Searched for "A", "B", "C", "D", etc., for real examples.
  • Now, found milestones more consistently.
  • Also serached for viewer(), members(), etc.

Diff Detail

Repository
rP Phabricator
Branch
milestone1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14818
Build 19386: Run Core Tests
Build 19385: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40930.Dec 9 2016, 1:34 PM
epriestley retitled this revision from to Tokenize datasource indexes on "(" and ")".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11955: Tag autocomplete doesn't always include milestones.
epriestley mentioned this in T11955: Tag autocomplete doesn't always include milestones.Dec 9 2016, 1:36 PM
epriestley updated this revision to Diff 40931.Dec 9 2016, 1:38 PM
  • Bonus test case.
chad accepted this revision.Dec 9 2016, 3:53 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 9 2016, 3:53 PM
Closed by commit rP5a95efaa4b77: Tokenize datasource indexes on "(" and ")" (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2016, 4:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
typeahead/
datasource/
4 lines
__tests__/
12 lines

Diff 40931

View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/__tests__/PhabricatorTypeaheadDatasourceTestCase.php

Loading...
Phabricator · Built by Phacility