Page MenuHomePhabricator
Differential D16999

Introduce a serializing key-value cache proxy
ClosedPublic
Actions

Authored by epriestley on Dec 6 2016, 1:12 PM.
Tags
None
Referenced Files
F14390078: D16999.id40902.diff
Sat, Dec 21, 6:07 PM
Unknown Object (File)
Wed, Dec 18, 12:33 PM
Unknown Object (File)
Wed, Dec 18, 12:33 PM
Unknown Object (File)
Wed, Dec 18, 12:33 PM
Unknown Object (File)
Mon, Dec 9, 7:28 AM
Unknown Object (File)
Mon, Dec 9, 7:28 AM
Unknown Object (File)
Mon, Dec 9, 7:26 AM
Unknown Object (File)
Mon, Dec 9, 7:17 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching
Commits
rP125fb332de72: Introduce a serializing key-value cache proxy
Summary

Ref T11954. I want to store some lists/arrays in the mutable (database) cache, but it only supports string storage.

Provide a serializing wrapper which flattens when values are written and expands them when they're read.

Test Plan

Used by D16997. See that revision.

Diff Detail

Repository
rP Phabricator
Branch
ccache6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14777
Build 19323: Run Core Tests
Build 19322: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40891.Dec 6 2016, 1:12 PM
epriestley retitled this revision from to Introduce a serializing key-value cache proxy.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching.
chad accepted this revision.Dec 6 2016, 4:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2016, 4:32 PM
Closed by commit rP125fb332de72: Introduce a serializing key-value cache proxy (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2016, 5:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40891

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/cache/PhabricatorCaches.php

Loading...
View Options

src/applications/cache/PhabricatorKeyValueSerializingCacheProxy.php

Loading...
Phabricator · Built by Phacility