Page MenuHomePhabricator

Use PhabricatorCachedClassMapQuery when querying object PHID types
ClosedPublic

Authored by epriestley on Dec 6 2016, 12:35 PM.
Tags
None
Referenced Files
F14341738: D16997.diff
Wed, Dec 18, 8:08 PM
F14322176: D16997.id40900.diff
Wed, Dec 18, 12:33 PM
F14322175: D16997.id40889.diff
Wed, Dec 18, 12:33 PM
F14322172: D16997.id.diff
Wed, Dec 18, 12:32 PM
Unknown Object (File)
Mon, Dec 9, 7:28 AM
Unknown Object (File)
Mon, Dec 9, 7:28 AM
Unknown Object (File)
Mon, Dec 9, 7:26 AM
Unknown Object (File)
Mon, Dec 9, 7:17 AM
Subscribers
None

Details

Summary

Ref T11954. When we query for Conduit tokens, we load the associated objects (users) by PHID.

Currently, querying objects by PHID requires us to load every PHIDType class, when we can know which specific classes we actually need (e.g., just UserPHIDType, if only user PHIDs are present in the query).

Use PhabricatorCachedClassMapQuery to reduce the number of classes we load on this pathway.

Test Plan
  • Used ab -n100 to roughly measure a ~5% performance improvement?
  • This measurement feels a little flimsy but the XHProf profile is cleaner, at least.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use PhabricatorCachedClassMapQuery when querying object PHID types.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2016, 4:21 PM