Page MenuHomePhabricator
Differential D16995

Use PhabricatorCachedClassMapQuery in Conduit method lookups
ClosedPublic
Actions

Authored by epriestley on Dec 6 2016, 12:15 PM.
Tags
None
Referenced Files
F14064762: D16995.diff
Tue, Nov 19, 1:07 AM
F14064678: D16995.id.diff
Tue, Nov 19, 12:44 AM
F13998910: D16995.diff
Thu, Oct 24, 11:47 AM
F13990645: D16995.diff
Tue, Oct 22, 5:14 AM
F13983855: D16995.id40898.diff
Sun, Oct 20, 9:11 AM
F13961827: D16995.id.diff
Oct 15 2024, 6:33 AM
Unknown Object (File)
Sep 25 2024, 9:49 AM
Unknown Object (File)
Sep 16 2024, 8:30 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching
Commits
rP55a54facd5db: Use PhabricatorCachedClassMapQuery in Conduit method lookups
Summary

Ref T11954. Depends on D16994. This implements the Conduit method cache described in that revision for a small global Conduit performance improvement.

Test Plan

Verified Conduit has the same behavior at lower cost. See D16994 for details.

Diff Detail

Repository
rP Phabricator
Branch
ccache3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14773
Build 19315: Run Core Tests
Build 19314: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40887.Dec 6 2016, 12:15 PM
epriestley retitled this revision from to Use PhabricatorCachedClassMapQuery in Conduit method lookups.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching.
epriestley added a parent revision: D16994: Provide a cached class map query for making key-based class lookups more efficient.
chad accepted this revision.Dec 6 2016, 3:11 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2016, 3:11 PM
Closed by commit rP55a54facd5db: Use PhabricatorCachedClassMapQuery in Conduit method lookups (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2016, 4:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
method/
13 lines

Diff 40887

View Options

src/applications/conduit/method/ConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility