Differential D16995

Use PhabricatorCachedClassMapQuery in Conduit method lookups
ClosedPublic
Actions

Authored by epriestley on Dec 6 2016, 12:15 PM.

Details

Reviewers

chad

Maniphest Tasks

T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching

Commits

rP55a54facd5db: Use PhabricatorCachedClassMapQuery in Conduit method lookups

Summary

Ref T11954. Depends on D16994. This implements the Conduit method cache described in that revision for a small global Conduit performance improvement.

Test Plan

Verified Conduit has the same behavior at lower cost. See D16994 for details.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40887.Dec 6 2016, 12:15 PM

epriestley retitled this revision from to Use PhabricatorCachedClassMapQuery in Conduit method lookups.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching.

epriestley added a parent revision: D16994: Provide a cached class map query for making key-based class lookups more efficient.

chad accepted this revision.Dec 6 2016, 3:11 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 6 2016, 3:11 PM

Closed by commit rP55a54facd5db: Use PhabricatorCachedClassMapQuery in Conduit method lookups (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2016, 4:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

ConduitAPIMethod.php

13 lines

Diff 40898

View Options

src/applications/conduit/method/ConduitAPIMethod.php

Use PhabricatorCachedClassMapQuery in Conduit method lookupsClosedPublicActions