Differential D16992

Give PhutilClassMapQuery a public cache key
ClosedPublic
Actions

Authored by epriestley on Dec 6 2016, 12:03 PM.

Details

Reviewers

chad

Maniphest Tasks

T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching

Commits

rPHU7009bcd3fb9b: Give PhutilClassMapQuery a public cache key

Summary

Ref T11954. This supports building a cache on top of this query, which future changes eventually use to improve Arcanist/Conduit performance.

Test Plan

See future changes.

Diff Detail

Repository

rPHU libphutil

Branch

ccache0

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14769
Build 19307: Run Core Tests
Build 19306: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40883.Dec 6 2016, 12:03 PM

epriestley retitled this revision from to Give PhutilClassMapQuery a public cache key.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching.

epriestley added a child revision: D16993: Provide a pure APC cache for runtime caching.Dec 6 2016, 12:08 PM

O.O

This revision is now accepted and ready to land.Dec 6 2016, 2:40 PM

Closed by commit rPHU7009bcd3fb9b: Give PhutilClassMapQuery a public cache key (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2016, 4:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

symbols/

PhutilClassMapQuery.php

2 lines

Diff 40883

View Options

src/symbols/PhutilClassMapQuery.php

Give PhutilClassMapQuery a public cache keyClosedPublicActions