Page MenuHomePhabricator
Differential D16959

Close lightbox when clicking on image-frame
ClosedPublic
Actions

Authored by chad on Nov 29 2016, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 5:59 AM
Unknown Object (File)
Fri, May 3, 3:52 PM
Unknown Object (File)
Fri, May 3, 3:38 AM
Unknown Object (File)
Mon, Apr 29, 4:31 PM
Unknown Object (File)
Wed, Apr 24, 11:39 PM
Unknown Object (File)
Fri, Apr 19, 5:47 PM
Unknown Object (File)
Wed, Apr 17, 5:21 PM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
View All Files
Subscribers
Korvin
Tokens
"Dat Boi" token, awarded by cspeckmim.

Details

Reviewers
epriestley
Maniphest Tasks
T3612: Lightbox v2
Commits
rPd1838fa5ec5e: Close lightbox when clicking on image-frame
Summary

Ref T3612. Moves the listener to the frame of the image.

Test Plan

Click on image, no close, click on grey frame, closes image. Test image and document, clicking on arrows.

Diff Detail

Repository
rP Phabricator
Branch
lightblock-click (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14701
Build 19207: Run Core Tests
Build 19206: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40813.Nov 29 2016, 5:21 PM
chad retitled this revision from to Close lightbox when clicking on image-frame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 29 2016, 5:21 PM
cspeckmim awarded a token.Nov 29 2016, 5:24 PM
epriestley accepted this revision.Nov 29 2016, 6:34 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2016, 6:34 PM
Closed by commit rPd1838fa5ec5e: Close lightbox when clicking on image-frame (authored by chad, committed by chad). · Explain WhyNov 29 2016, 6:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
30 lines
webroot/
rsrc/
css/
phui/
1 line
js/
core/
5 lines

Diff 40813

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-lightbox.css

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility