Page MenuHomePhabricator
Differential D16937

Fix an issue where an excessively long TTL was computed for "not attending anything" event caches
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 11:10 PM.
Tags
None
Referenced Files
F14350060: D16937.diff
Thu, Dec 19, 6:51 AM
Unknown Object (File)
Mon, Dec 9, 11:47 PM
Unknown Object (File)
Sat, Nov 30, 11:11 AM
Unknown Object (File)
Nov 11 2024, 9:16 AM
Unknown Object (File)
Nov 1 2024, 10:18 PM
Unknown Object (File)
Oct 24 2024, 7:11 AM
Unknown Object (File)
Oct 24 2024, 4:19 AM
Unknown Object (File)
Oct 15 2024, 2:30 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11894: Calendar "away icons" do not automatically appear
Commits
rPeac49e421a41: Fix an issue where an excessively long TTL was computed for "not attending…
Summary

Fixes T11894. Currently, if you aren't attending any events for a while, we can cache that you are free for the next 72 hours, even if you have an event in a few hours.

Instead, only cache "user is free" until the next event, if one exists.

Test Plan

Dumped cache TTLs, saw 52 minutes instead of ~4300 minutes with a near-upcoming event.

Diff Detail

Repository
rP Phabricator
Branch
cal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14656
Build 19140: Run Core Tests
Build 19139: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40768.Nov 23 2016, 11:10 PM
epriestley retitled this revision from to Fix an issue where an excessively long TTL was computed for "not attending anything" event caches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11894: Calendar "away icons" do not automatically appear.
epriestley mentioned this in T11894: Calendar "away icons" do not automatically appear.Nov 23 2016, 11:16 PM
chad accepted this revision.Nov 23 2016, 11:16 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 11:16 PM
Closed by commit rPeac49e421a41: Fix an issue where an excessively long TTL was computed for "not attending… (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 11:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
query/
9 lines

Diff 40768

View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
Phabricator · Built by Phacility