Page MenuHomePhabricator

Fix an issue where an excessively long TTL was computed for "not attending anything" event caches
ClosedPublic

Authored by epriestley on Nov 23 2016, 11:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 22, 3:42 AM
Unknown Object (File)
Fri, Feb 16, 7:06 PM
Unknown Object (File)
Feb 3 2024, 1:10 PM
Unknown Object (File)
Jan 20 2024, 1:42 AM
Unknown Object (File)
Jan 9 2024, 10:25 AM
Unknown Object (File)
Dec 27 2023, 8:29 AM
Unknown Object (File)
Dec 24 2023, 6:33 AM
Unknown Object (File)
Dec 22 2023, 6:37 AM
Subscribers
None

Details

Summary

Fixes T11894. Currently, if you aren't attending any events for a while, we can cache that you are free for the next 72 hours, even if you have an event in a few hours.

Instead, only cache "user is free" until the next event, if one exists.

Test Plan

Dumped cache TTLs, saw 52 minutes instead of ~4300 minutes with a near-upcoming event.

Diff Detail

Repository
rP Phabricator
Branch
cal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14656
Build 19140: Run Core Tests
Build 19139: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix an issue where an excessively long TTL was computed for "not attending anything" event caches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 11:16 PM
This revision was automatically updated to reflect the committed changes.