Page MenuHomePhabricator
Differential D16933

Implement a revision resolver for `arc browse <commit>`
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 7:50 PM.
Tags
None
Referenced Files
F13990245: D16933.diff
Tue, Oct 22, 2:12 AM
F13968440: D16933.id40762.diff
Wed, Oct 16, 9:04 PM
F13963828: D16933.id40757.diff
Tue, Oct 15, 6:07 PM
Unknown Object (File)
Oct 9 2024, 6:18 AM
Unknown Object (File)
Oct 1 2024, 11:22 PM
Unknown Object (File)
Sep 12 2024, 1:34 PM
Unknown Object (File)
Aug 25 2024, 8:59 AM
Unknown Object (File)
Aug 18 2024, 10:17 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`
Commits
rARC84857e48900e: Implement a revision resolver for `arc browse <commit>`
Summary

Ref T10895. This allows arc browse <commit name> to resolve to a revision, if an associated open revision exists.

Test Plan

Ran arc browse with various arguments.

Diff Detail

Repository
rARC Arcanist
Branch
xp6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/ref/ArcanistRevisionRef.php:32XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14646
Build 19127: Run Core Tests
Build 19126: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40757.Nov 23 2016, 7:50 PM
epriestley retitled this revision from to Implement a revision resolver for `arc browse <commit>`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.
epriestley mentioned this in T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.Nov 23 2016, 8:07 PM
chad accepted this revision.Nov 23 2016, 8:57 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 8:57 PM
Closed by commit rARC84857e48900e: Implement a revision resolver for `arc browse <commit>` (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 9:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40757

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/browse/loader/ArcanistBrowseCommitHardpointLoader.php

Loading...
View Options

src/browse/loader/ArcanistBrowseCommitURIHardpointLoader.php

Loading...
View Options

src/browse/loader/ArcanistBrowseRevisionURIHardpointLoader.php

Loading...
View Options

src/browse/workflow/ArcanistBrowseWorkflow.php

Loading...
View Options

src/loader/ArcanistGitCommitMessageHardpointLoader.php

Loading...
View Options

src/loader/ArcanistGitRevisionHardpointLoader.php

Loading...
View Options

src/ref/ArcanistRevisionRef.php

Loading...
Phabricator · Built by Phacility