Page MenuHomePhabricator

Implement a revision resolver for `arc browse <commit>`
ClosedPublic

Authored by epriestley on Nov 23 2016, 7:50 PM.
Tags
None
Referenced Files
F11026047: D16933.diff
Fri, Aug 12, 3:19 PM
Unknown Object (File)
Wed, Aug 3, 8:10 PM
Unknown Object (File)
Fri, Jul 29, 3:54 PM
Unknown Object (File)
Mon, Jul 25, 11:32 AM
Unknown Object (File)
Mon, Jul 25, 11:32 AM
Unknown Object (File)
Mon, Jul 25, 11:32 AM
Unknown Object (File)
Sun, Jul 17, 3:20 PM
Unknown Object (File)
Thu, Jul 14, 7:54 AM
Subscribers
None

Details

Summary

Ref T10895. This allows arc browse <commit name> to resolve to a revision, if an associated open revision exists.

Test Plan

Ran arc browse with various arguments.

Diff Detail

Repository
rARC Arcanist
Branch
xp6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/ref/ArcanistRevisionRef.php:32XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14646
Build 19127: Run Core Tests
Build 19126: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Implement a revision resolver for `arc browse <commit>`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 8:57 PM
This revision was automatically updated to reflect the committed changes.