Paths

Table of Contentst

Allow "Wait for Message" to be unset on build plans
ClosedPublic
Actions

Authored by epriestley on Nov 22 2016, 9:48 PM.

Details

Reviewers

avivey
chad

Maniphest Tasks

T11910: Cannot unset Build Plan Step's "Wait For Message" option

Commits

rPfaf42cbe8f59: Allow "Wait for Message" to be unset on build plans

Summary

Fixes T11910. I spent a couple of minutes looking for the root cause without much luck, but this will all be obsoleted by an eventual upgrade to EditEngine anyway.

Test Plan

Set and unset "Wait for Message", which now worked.

Diff Detail

Repository

rP Phabricator

Branch

buildstep1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14623
Build 19093: Run Core Tests
Build 19092: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40731.Nov 22 2016, 9:48 PM

epriestley retitled this revision from to Allow "Wait for Message" to be unset on build plans.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, avivey.

epriestley added a task: T11910: Cannot unset Build Plan Step's "Wait For Message" option.

Owners added a subscriber: Restricted Owners Package.Nov 22 2016, 9:48 PM

avivey accepted this revision.Nov 22 2016, 10:02 PM

avivey edited edge metadata.

This revision is now accepted and ready to land.Nov 22 2016, 10:02 PM

Closed by commit rPfaf42cbe8f59: Allow "Wait for Message" to be unset on build plans (authored by epriestley, committed by epriestley). · Explain WhyNov 22 2016, 10:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

customfield/

HarbormasterBuildStepCoreCustomField.php

2 lines

step/

HarbormasterBuildStepImplementation.php

3 lines

Diff 40731

View Options

src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php