Page MenuHomePhabricator

Fix a Quicksand/Lightbox contention issue
ClosedPublic

Authored by epriestley on Nov 17 2016, 12:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 12:51 AM
Unknown Object (File)
Fri, Jan 24, 5:52 PM
Unknown Object (File)
Tue, Jan 21, 11:15 AM
Unknown Object (File)
Tue, Jan 21, 10:54 AM
Unknown Object (File)
Mon, Jan 20, 4:30 PM
Unknown Object (File)
Sat, Jan 18, 12:17 AM
Unknown Object (File)
Sun, Jan 5, 11:30 PM
Unknown Object (File)
Thu, Jan 2, 1:47 AM
Subscribers
None

Details

Summary

Fixes T11785. Lightbox calls JX.Stratcom.pass() to let other handlers react, but should not. At least today, we never put, e.g., links inside a lightbox.

This code appears in the original commit so it was probably just copy/pasted from somewhere and I missed it in review.

(Or there's some edge case I'm not thinking of and we'll figure it out soon enough.)

Additionally, blacklist /file/data/ from Quicksand naviagtion: Quicksand should never fetch these URIs.

Test Plan
  • Disabled security.alternate-file-domain.
  • Enabled Quicksand ("Persistent Chat").
  • Clicked an image thumbnail on a task.
    • Repeated that until things flipped out a bit.
    • After the patch: no issues.

Diff Detail

Repository
rP Phabricator
Branch
quicksand1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14537
Build 18961: Run Core Tests
Build 18960: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a Quicksand/Lightbox contention issue.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 1:09 AM
This revision was automatically updated to reflect the committed changes.