Page MenuHomePhabricator

Fix a Quicksand/Lightbox contention issue
ClosedPublic

Authored by epriestley on Nov 17 2016, 12:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 11:30 AM
Unknown Object (File)
Wed, Nov 27, 8:10 PM
Unknown Object (File)
Sat, Nov 23, 3:40 AM
Unknown Object (File)
Oct 18 2024, 5:37 PM
Unknown Object (File)
Oct 4 2024, 4:57 AM
Unknown Object (File)
Sep 12 2024, 3:51 PM
Unknown Object (File)
Sep 12 2024, 5:22 AM
Unknown Object (File)
Sep 11 2024, 10:21 PM
Subscribers
None

Details

Summary

Fixes T11785. Lightbox calls JX.Stratcom.pass() to let other handlers react, but should not. At least today, we never put, e.g., links inside a lightbox.

This code appears in the original commit so it was probably just copy/pasted from somewhere and I missed it in review.

(Or there's some edge case I'm not thinking of and we'll figure it out soon enough.)

Additionally, blacklist /file/data/ from Quicksand naviagtion: Quicksand should never fetch these URIs.

Test Plan
  • Disabled security.alternate-file-domain.
  • Enabled Quicksand ("Persistent Chat").
  • Clicked an image thumbnail on a task.
    • Repeated that until things flipped out a bit.
    • After the patch: no issues.

Diff Detail

Repository
rP Phabricator
Branch
quicksand1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14537
Build 18961: Run Core Tests
Build 18960: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a Quicksand/Lightbox contention issue.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 1:09 AM
This revision was automatically updated to reflect the committed changes.