Page MenuHomePhabricator
Differential D16849

Fix some slop with Differential field lists
ClosedPublic
Actions

Authored by epriestley on Nov 13 2016, 12:25 AM.
Tags
None
Referenced Files
F15455156: D16849.id40572.diff
Sat, Mar 29, 10:34 PM
F15454731: D16849.id.diff
Sat, Mar 29, 8:00 PM
F15452719: D16849.id40573.diff
Sat, Mar 29, 6:55 AM
F15451170: D16849.diff
Fri, Mar 28, 8:34 PM
F15444375: D16849.diff
Thu, Mar 27, 9:20 AM
F15401027: D16849.id.diff
Mon, Mar 17, 3:18 PM
F15390666: D16849.id40572.diff
Sat, Mar 15, 6:25 AM
F15390431: D16849.diff
Sat, Mar 15, 6:12 AM
View All Files
Subscribers
None

Details

Reviewers
chad
jacksongabbard
Commits
rP745429aac1ea: Fix some slop with Differential field lists
Summary

I moved and then un-moved this incorrectly in D16846.

Test Plan

Looked at the old code, which worked better.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40572.Nov 13 2016, 12:25 AM
epriestley retitled this revision from to Fix some slop with Differential field lists.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: jacksongabbard, chad.
chad accepted this revision.Nov 13 2016, 12:26 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 13 2016, 12:26 AM
Closed by commit rP745429aac1ea: Fix some slop with Differential field lists (authored by epriestley, committed by epriestley). · Explain WhyNov 13 2016, 12:27 AM
This revision was automatically updated to reflect the committed changes.
jacksongabbard edited edge metadata.Nov 13 2016, 12:29 AM

Macro happycat:

epriestley added a comment.Nov 13 2016, 12:30 AM

Don't get too excited, I'm going to break everything in a second.

chad added a comment.Nov 13 2016, 12:30 AM

pull now PULL NOW

epriestley added a comment.Nov 13 2016, 12:33 AM

too late

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
2 lines

Diff 40573

View Options

src/applications/differential/conduit/DifferentialParseCommitMessageConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility