Fix some slop with Differential field lists
ClosedPublic
Actions

Authored by epriestley on Nov 13 2016, 12:25 AM.

Tags

None

Referenced Files

	F15504759: D16849.diff
	Mon, Apr 14, 8:27 PM

	F15455156: D16849.id40572.diff
	Sat, Mar 29, 10:34 PM

	F15454731: D16849.id.diff
	Sat, Mar 29, 8:00 PM

	F15452719: D16849.id40573.diff
	Sat, Mar 29, 6:55 AM

	F15451170: D16849.diff
	Fri, Mar 28, 8:34 PM

	F15444375: D16849.diff
	Thu, Mar 27, 9:20 AM

	F15401027: D16849.id.diff
	Mar 17 2025, 3:18 PM

	F15390666: D16849.id40572.diff
	Mar 15 2025, 6:25 AM

View All Files

Subscribers

None

Details

Reviewers

chad
jacksongabbard

Commits

rP745429aac1ea: Fix some slop with Differential field lists

Summary

I moved and then un-moved this incorrectly in D16846.

Test Plan

Looked at the old code, which worked better.

Diff Detail

Repository

rP Phabricator

Branch

slop1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14464
Build 18855: Run Core Tests
Build 18854: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40572.Nov 13 2016, 12:25 AM

epriestley retitled this revision from to Fix some slop with Differential field lists.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: jacksongabbard, chad.

chad accepted this revision.Nov 13 2016, 12:26 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 13 2016, 12:26 AM

Closed by commit rP745429aac1ea: Fix some slop with Differential field lists (authored by epriestley, committed by epriestley). · Explain WhyNov 13 2016, 12:27 AM

This revision was automatically updated to reflect the committed changes.

Macro happycat:

Don't get too excited, I'm going to break everything in a second.

pull now PULL NOW

too late

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialParseCommitMessageConduitAPIMethod.php

2 lines

Diff 40572

View Options

src/applications/differential/conduit/DifferentialParseCommitMessageConduitAPIMethod.php

Fix some slop with Differential field listsClosedPublicActions