Support multiple database masters and convert easy callers
ClosedPublic
Actions

Authored by epriestley on Jun 14 2016, 6:15 PM.

Details

Reviewers

chad

Maniphest Tasks

T11044: Support partitioning application databases across multiple database hosts

Commits

rPecc598f18dc4: Support multiple database masters and convert easy callers

Summary

Ref T11044. This moves toward partitioned application databases:

You can define multiple masters.
Convert all the easily-convertible code to become multi-master aware.

This doesn't convert most of bin/storage or "Config > Database (Stuff)" yet, as both are quite involved. They still work for now, but only operate on the first master instead of all masters.

Test Plan

Configured multiple masters, browsed around, ran bin/storage commands, ran bin/storage --host ....

Diff Detail

Repository

rP Phabricator

Branch

part1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/infrastructure/cluster/PhabricatorDatabaseRef.php:470	XHP16	TODO Comment
Advice	src/infrastructure/cluster/PhabricatorDatabaseRef.php:479	XHP16	TODO Comment
Advice	src/infrastructure/cluster/PhabricatorDatabaseRef.php:523	XHP16	TODO Comment
Advice	src/infrastructure/cluster/PhabricatorDatabaseRef.php:525	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 14463
Build 18853: Run Core Tests
Build 18852: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38775.Jun 14 2016, 6:15 PM

epriestley retitled this revision from to Support multiple database masters and convert easy callers.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11044: Support partitioning application databases across multiple database hosts.

Let me get a little further before you look at any of this, doing the "hard part" might change how this looks by either testing it better or adjusting APIs.

epriestley added a child revision: D16847: Update SchemaQuery and the web UI to accommodate multiple master databases.Nov 12 2016, 5:37 PM