Page MenuHomePhabricator
Differential D16115

Support multiple database masters and convert easy callers
ClosedPublic
Actions

Authored by epriestley on Jun 14 2016, 6:15 PM.
Tags
None
Referenced Files
F13134683: D16115.diff
Thu, May 2, 4:32 AM
Unknown Object (File)
Mon, Apr 29, 6:19 PM
Unknown Object (File)
Thu, Apr 25, 11:55 PM
Unknown Object (File)
Thu, Apr 25, 11:54 PM
Unknown Object (File)
Thu, Apr 25, 11:54 PM
Unknown Object (File)
Thu, Apr 25, 11:54 PM
Unknown Object (File)
Thu, Apr 25, 11:41 PM
Unknown Object (File)
Thu, Apr 25, 1:45 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11044: Support partitioning application databases across multiple database hosts
Commits
rPecc598f18dc4: Support multiple database masters and convert easy callers
Summary

Ref T11044. This moves toward partitioned application databases:

  • You can define multiple masters.
  • Convert all the easily-convertible code to become multi-master aware.

This doesn't convert most of bin/storage or "Config > Database (Stuff)" yet, as both are quite involved. They still work for now, but only operate on the first master instead of all masters.

Test Plan

Configured multiple masters, browsed around, ran bin/storage commands, ran bin/storage --host ....

Diff Detail

Event Timeline

epriestley updated this revision to Diff 38775.Jun 14 2016, 6:15 PM
epriestley retitled this revision from to Support multiple database masters and convert easy callers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11044: Support partitioning application databases across multiple database hosts.
epriestley planned changes to this revision.Jun 14 2016, 6:36 PM

Let me get a little further before you look at any of this, doing the "hard part" might change how this looks by either testing it better or adjusting APIs.

epriestley added a child revision: D16847: Update SchemaQuery and the web UI to accommodate multiple master databases.Nov 12 2016, 5:37 PM
epriestley updated this revision to Diff 40571.Nov 12 2016, 8:07 PM
  • Rebase, this didn't end up needing any major changes.
chad accepted this revision.Nov 12 2016, 8:28 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 12 2016, 8:28 PM
Closed by commit rPecc598f18dc4: Support multiple database masters and convert easy callers (authored by epriestley, committed by epriestley). · Explain WhyNov 13 2016, 12:30 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11044: Support partitioning application databases across multiple database hosts.Nov 13 2016, 12:48 AM

Revision Contents
Changeset List

PathSize
scripts/
sql/
4 lines
src/
applications/
config/
check/
111 lines
infrastructure/
cluster/
8 lines
53 lines
env/
23 lines
storage/
lisk/
6 lines

Diff 38775

View Options

scripts/sql/manage_storage.php

Loading...
View Options

src/applications/config/check/PhabricatorDatabaseSetupCheck.php

Loading...
View Options

src/infrastructure/cluster/PhabricatorClusterDatabasesConfigOptionType.php

Loading...
View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Loading...
View Options

src/infrastructure/env/PhabricatorEnv.php

Loading...
View Options

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Loading...
Phabricator · Built by Phacility