Page MenuHomePhabricator

Probably fix some display issues with all-day events?
ClosedPublic

Authored by epriestley on Nov 7 2016, 6:44 PM.
Tags
None
Referenced Files
F15460789: D16815.id40493.diff
Tue, Apr 1, 2:13 AM
F15459527: D16815.id.diff
Mon, Mar 31, 1:46 PM
F15442851: D16815.id40493.diff
Thu, Mar 27, 12:52 AM
F15430222: D16815.id.diff
Mon, Mar 24, 6:32 AM
F15429643: D16815.id40490.diff
Mon, Mar 24, 3:27 AM
F15427498: D16815.diff
Sun, Mar 23, 2:42 PM
F15396918: D16815.id.diff
Sun, Mar 16, 4:58 PM
F15332658: D16815.diff
Fri, Mar 7, 6:56 PM
Subscribers
None

Details

Summary

Ref T11801. These are pretty fiddly because users expect to see the end time for timed events ("10 AM - 11 AM" is ONE hour long) but not for all-day events ("Nov 2 - Nov 3" is TWO days long!)

We also want to store the thing the user actually entered so we don't lose data if they un-all-day the event later.

This may take a little more fiddling since it feels a little shaky, but I couldn't break this version immediately.

Test Plan

Imported a French holiday, got proper display in the UI.

Diff Detail

Repository
rP Phabricator
Branch
cal3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14381
Build 18728: Run Core Tests
Build 18727: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Probably fix some display issues with all-day events?.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 6:50 PM
This revision was automatically updated to reflect the committed changes.