Page MenuHomePhabricator

Probably fix some display issues with all-day events?
ClosedPublic

Authored by epriestley on Nov 7 2016, 6:44 PM.
Tags
None
Referenced Files
F12805382: D16815.id40493.diff
Wed, Mar 27, 5:15 PM
F12805381: D16815.id40490.diff
Wed, Mar 27, 5:15 PM
F12805379: D16815.id.diff
Wed, Mar 27, 5:14 PM
Unknown Object (File)
Thu, Mar 14, 5:26 AM
Unknown Object (File)
Feb 17 2024, 10:52 AM
Unknown Object (File)
Feb 14 2024, 2:10 PM
Unknown Object (File)
Feb 14 2024, 2:09 PM
Unknown Object (File)
Feb 14 2024, 2:09 PM
Subscribers
None

Details

Summary

Ref T11801. These are pretty fiddly because users expect to see the end time for timed events ("10 AM - 11 AM" is ONE hour long) but not for all-day events ("Nov 2 - Nov 3" is TWO days long!)

We also want to store the thing the user actually entered so we don't lose data if they un-all-day the event later.

This may take a little more fiddling since it feels a little shaky, but I couldn't break this version immediately.

Test Plan

Imported a French holiday, got proper display in the UI.

Diff Detail

Repository
rP Phabricator
Branch
cal3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14381
Build 18728: Run Core Tests
Build 18727: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Probably fix some display issues with all-day events?.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 6:50 PM
This revision was automatically updated to reflect the committed changes.