Page MenuHomePhabricator

Smooth out various transaction/editing behaviors for Calendar
ClosedPublic

Authored by epriestley on Nov 2 2016, 10:43 PM.
Tags
None
Referenced Files
F13134751: D16796.diff
Thu, May 2, 4:54 AM
F13134468: D16796.diff
Thu, May 2, 3:13 AM
Unknown Object (File)
Fri, Apr 19, 5:34 PM
Unknown Object (File)
Fri, Apr 19, 2:53 AM
Unknown Object (File)
Thu, Apr 11, 10:11 AM
Unknown Object (File)
Mon, Apr 8, 1:44 AM
Unknown Object (File)
Fri, Apr 5, 6:45 AM
Unknown Object (File)
Apr 2 2024, 5:45 AM
Subscribers
None

Details

Summary

Ref T11809.

  • Allow users to remove the "Until" date from recurring events.
  • When removing "Until", show a sensible string ("...set this event to repeat forever.")
  • When users go through the "Make Recurring" workflow, don't require them to explicitly select "Recurring: Recurring" from the dropdown. This intent is clear from clicking "Make Recurring".
  • When editing "All Future Events", don't literally apply date changes to them, since that doesn't make sense. We update the template, then reschedule any events which haven't been edited already. I think this is what users probably mean if they make this edit.
  • When creating an event with a non-default icon, don't show "alice changed the icon from Default to Party.".
  • Hide the "recurring mode" transaction, which had no string ("alice edited this Event.") and was redundant anyway.
  • Also, add a little piece of developer text to make hunting these things down easier.
Test Plan

Edited various events, parents, children, made events recur, set until, unset until, viewed transactions, rescheduled parents, rescheduled children.

Diff Detail

Repository
rP Phabricator
Branch
cal5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14342
Build 18671: Run Core Tests
Build 18670: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Smooth out various transaction/editing behaviors for Calendar.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 3 2016, 3:09 AM
This revision was automatically updated to reflect the committed changes.