Page MenuHomePhabricator

Fix some minor Calendar issues, including a paging issue on imports
ClosedPublic

Authored by epriestley on Nov 1 2016, 8:59 PM.
Tags
None
Referenced Files
F19825204: D16787.id.diff
Sun, Mar 8, 8:56 AM
F19523274: D16787.diff
Jan 17 2026, 3:06 PM
F19505302: D16787.diff
Jan 9 2026, 10:51 AM
F19353461: D16787.id40430.diff
Dec 26 2025, 5:18 AM
F19040071: D16787.id.diff
Nov 26 2025, 10:43 AM
F19031980: D16787.diff
Nov 25 2025, 3:53 AM
F18824611: D16787.id40430.diff
Oct 23 2025, 4:47 PM
F18816071: D16787.id.diff
Oct 21 2025, 4:48 AM
Subscribers
None

Details

Summary

Fixes T11808. I couldn't reproduce the issue there locally so I'm just cheating a little bit until a better reproduction case shows up.

We don't need to do a full load here anyway, and testing for any row is more efficient.

Test Plan

Poked around imports without issues, but couldn't reproduce this problem locally.

Diff Detail

Repository
rP Phabricator
Branch
cal13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14320
Build 18636: Run Core Tests
Build 18635: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix some minor Calendar issues, including a paging issue on imports.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Also fix an issue importing events with no attendees that I caught in the production logs.
  • Also fix an issue which could cause reminder notifications for events which started up to 5 minutes ago.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 1 2016, 9:39 PM
This revision was automatically updated to reflect the committed changes.