Page MenuHomePhabricator

Fix some minor Calendar issues, including a paging issue on imports
ClosedPublic

Authored by epriestley on Nov 1 2016, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 10:32 PM
Unknown Object (File)
Wed, Mar 20, 10:32 PM
Unknown Object (File)
Wed, Mar 20, 10:32 PM
Unknown Object (File)
Tue, Mar 5, 2:03 AM
Unknown Object (File)
Feb 16 2024, 11:39 AM
Unknown Object (File)
Feb 15 2024, 9:07 PM
Unknown Object (File)
Feb 6 2024, 8:40 PM
Unknown Object (File)
Jan 31 2024, 2:40 PM
Subscribers
None

Details

Summary

Fixes T11808. I couldn't reproduce the issue there locally so I'm just cheating a little bit until a better reproduction case shows up.

We don't need to do a full load here anyway, and testing for any row is more efficient.

Test Plan

Poked around imports without issues, but couldn't reproduce this problem locally.

Diff Detail

Repository
rP Phabricator
Branch
cal13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14321
Build 18638: Run Core Tests
Build 18637: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix some minor Calendar issues, including a paging issue on imports.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Also fix an issue importing events with no attendees that I caught in the production logs.
  • Also fix an issue which could cause reminder notifications for events which started up to 5 minutes ago.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 1 2016, 9:39 PM
This revision was automatically updated to reflect the committed changes.