Page MenuHomePhabricator
Differential D16787

Fix some minor Calendar issues, including a paging issue on imports
ClosedPublic
Actions

Authored by epriestley on Nov 1 2016, 8:59 PM.
Tags
None
Referenced Files
F14335758: D16787.diff
Wed, Dec 18, 5:38 PM
Unknown Object (File)
Fri, Dec 13, 11:41 PM
Unknown Object (File)
Fri, Dec 13, 3:52 AM
Unknown Object (File)
Tue, Nov 26, 10:45 PM
Unknown Object (File)
Fri, Nov 22, 7:43 PM
Unknown Object (File)
Fri, Nov 22, 5:09 AM
Unknown Object (File)
Nov 18 2024, 12:47 PM
Unknown Object (File)
Nov 14 2024, 9:10 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11808: Calendar has cursor paging issue on import sources
Commits
rP191b9398a5f6: Fix some minor Calendar issues, including a paging issue on imports
Summary

Fixes T11808. I couldn't reproduce the issue there locally so I'm just cheating a little bit until a better reproduction case shows up.

We don't need to do a full load here anyway, and testing for any row is more efficient.

Test Plan

Poked around imports without issues, but couldn't reproduce this problem locally.

Diff Detail

Repository
rP Phabricator
Branch
cal13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14322
Build 18640: Run Core Tests
Build 18639: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40430.Nov 1 2016, 8:59 PM
epriestley retitled this revision from to Fix some minor Calendar issues, including a paging issue on imports.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11808: Calendar has cursor paging issue on import sources.
epriestley updated this revision to Diff 40431.Nov 1 2016, 9:01 PM
  • Also fix an issue importing events with no attendees that I caught in the production logs.
epriestley updated this revision to Diff 40432.Nov 1 2016, 9:17 PM
  • Also fix an issue which could cause reminder notifications for events which started up to 5 minutes ago.
chad accepted this revision.Nov 1 2016, 9:39 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 1 2016, 9:39 PM
Closed by commit rP191b9398a5f6: Fix some minor Calendar issues, including a paging issue on imports (authored by epriestley, committed by epriestley). · Explain WhyNov 1 2016, 9:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
import/
20 lines
notifications/
5 lines
query/
2 lines

Diff 40432

View Options

src/applications/calendar/import/PhabricatorCalendarImportEngine.php

Loading...
View Options

src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...
Phabricator · Built by Phacility