Page MenuHomePhabricator

In Phabricator, drop PhutilClassMap caches after loading additional libraries
ClosedPublic

Authored by epriestley on Oct 26 2016, 10:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 1:44 AM
Unknown Object (File)
Feb 14 2024, 12:22 AM
Unknown Object (File)
Jan 23 2024, 11:29 AM
Unknown Object (File)
Jan 16 2024, 2:15 AM
Unknown Object (File)
Jan 14 2024, 1:00 AM
Unknown Object (File)
Jan 12 2024, 3:34 PM
Unknown Object (File)
Dec 15 2023, 6:32 PM
Unknown Object (File)
Nov 30 2023, 5:05 AM
Subscribers
None

Details

Summary

Depends on D16755. Right now, we build a setup check map (to run preflight checks), then later load libraries.

This means any checks included in third-party libraries don't get added to the map, and no longer run.

(These are rare, but Phacility has a couple).

Instead, delete the caches after loading extra libraries.

Test Plan

With this and D16755, re-ran setup checks and saw Phacility setup checks run.

Diff Detail

Repository
rP Phabricator
Branch
env1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14245
Build 18525: Run Core Tests
Build 18524: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to In Phabricator, drop PhutilClassMap caches after loading additional libraries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2016, 10:42 PM

(Build failure is from the unlanded dependency.)

This revision was automatically updated to reflect the committed changes.