Page MenuHomePhabricator

In Phabricator, drop PhutilClassMap caches after loading additional libraries
ClosedPublic

Authored by epriestley on Oct 26 2016, 10:26 PM.

Details

Summary

Depends on D16755. Right now, we build a setup check map (to run preflight checks), then later load libraries.

This means any checks included in third-party libraries don't get added to the map, and no longer run.

(These are rare, but Phacility has a couple).

Instead, delete the caches after loading extra libraries.

Test Plan

With this and D16755, re-ran setup checks and saw Phacility setup checks run.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to In Phabricator, drop PhutilClassMap caches after loading additional libraries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Oct 26 2016, 10:42 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2016, 10:42 PM

(Build failure is from the unlanded dependency.)

This revision was automatically updated to reflect the committed changes.