Page MenuHomePhabricator

Reject high-frequency and out-of-range events during import
ClosedPublic

Authored by epriestley on Oct 18 2016, 5:11 PM.
Tags
None
Referenced Files
F13281070: D16716.diff
Sun, Jun 2, 9:41 AM
F13268062: D16716.diff
Wed, May 29, 4:34 AM
F13255425: D16716.id.diff
Sat, May 25, 5:01 AM
F13253544: D16716.diff
Sat, May 25, 2:45 AM
F13240423: D16716.id40258.diff
Wed, May 22, 2:04 PM
F13239866: D16716.id40262.diff
Wed, May 22, 7:25 AM
F13239696: D16716.id.diff
Wed, May 22, 5:41 AM
F13239695: D16716.id40262.diff
Wed, May 22, 5:41 AM
Subscribers
None

Details

Summary

Ref T10747. Don't let users import SECONDLY events, or events outside of the range of a signed 32-bit integer (these are likely not too hard to support, but they're more headaches than we need right now).

Test Plan

Tried to import these no-good problem events, got helpful import errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Reject high-frequency and out-of-range events during import.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
88

haha

This revision is now accepted and ready to land.Oct 18 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.