Page MenuHomePhabricator

Reject high-frequency and out-of-range events during import
ClosedPublic

Authored by epriestley on Oct 18 2016, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 2, 9:54 PM
Unknown Object (File)
Jun 8 2026, 4:18 PM
Unknown Object (File)
Jun 4 2026, 12:53 AM
Unknown Object (File)
Apr 16 2026, 9:19 PM
Unknown Object (File)
Apr 15 2026, 11:41 PM
Unknown Object (File)
Apr 9 2026, 5:17 PM
Unknown Object (File)
Mar 12 2026, 3:58 AM
Unknown Object (File)
Mar 9 2026, 12:33 AM
Subscribers
None

Details

Summary

Ref T10747. Don't let users import SECONDLY events, or events outside of the range of a signed 32-bit integer (these are likely not too hard to support, but they're more headaches than we need right now).

Test Plan

Tried to import these no-good problem events, got helpful import errors.

Diff Detail

Repository
rP Phabricator
Branch
cimport9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14151
Build 18379: Run Core Tests
Build 18378: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Reject high-frequency and out-of-range events during import.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
88

haha

This revision is now accepted and ready to land.Oct 18 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.