Page MenuHomePhabricator

Reject high-frequency and out-of-range events during import
ClosedPublic

Authored by epriestley on Oct 18 2016, 5:11 PM.
Tags
None
Referenced Files
F13129867: D16716.diff
Wed, May 1, 3:38 AM
Unknown Object (File)
Mon, Apr 29, 8:13 PM
Unknown Object (File)
Thu, Apr 25, 7:15 AM
Unknown Object (File)
Wed, Apr 24, 11:53 PM
Unknown Object (File)
Fri, Apr 19, 5:29 PM
Unknown Object (File)
Thu, Apr 11, 8:09 AM
Unknown Object (File)
Mar 30 2024, 11:14 AM
Unknown Object (File)
Feb 11 2024, 7:42 PM
Subscribers
None

Details

Summary

Ref T10747. Don't let users import SECONDLY events, or events outside of the range of a signed 32-bit integer (these are likely not too hard to support, but they're more headaches than we need right now).

Test Plan

Tried to import these no-good problem events, got helpful import errors.

Diff Detail

Repository
rP Phabricator
Branch
cimport9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14151
Build 18379: Run Core Tests
Build 18378: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Reject high-frequency and out-of-range events during import.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
88

haha

This revision is now accepted and ready to land.Oct 18 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.