Page MenuHomePhabricator

Reject high-frequency and out-of-range events during import
ClosedPublic

Authored by epriestley on Oct 18 2016, 5:11 PM.
Tags
None
Referenced Files
F19800345: D16716.diff
Sat, Feb 28, 2:46 PM
F19668775: D16716.id.diff
Sat, Feb 7, 7:51 PM
F19569701: D16716.diff
Sun, Feb 1, 12:21 AM
F19084364: D16716.id.diff
Dec 2 2025, 3:20 PM
F18856220: D16716.id.diff
Nov 1 2025, 8:41 AM
F18811659: D16716.id40262.diff
Oct 20 2025, 4:09 AM
F18798474: D16716.id.diff
Oct 17 2025, 6:34 AM
F18737684: D16716.id40258.diff
Oct 1 2025, 11:59 AM
Subscribers
None

Details

Summary

Ref T10747. Don't let users import SECONDLY events, or events outside of the range of a signed 32-bit integer (these are likely not too hard to support, but they're more headaches than we need right now).

Test Plan

Tried to import these no-good problem events, got helpful import errors.

Diff Detail

Repository
rP Phabricator
Branch
cimport9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14151
Build 18379: Run Core Tests
Build 18378: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Reject high-frequency and out-of-range events during import.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
88

haha

This revision is now accepted and ready to land.Oct 18 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.