Page MenuHomePhabricator
Differential D16712

Fixed undefined variable error in call from ConduitIntListParameterType
ClosedPublic
Actions

Authored by gd on Oct 17 2016, 12:16 PM.
Tags
None
Referenced Files
F15512837: D16712.id40246.diff
Thu, Apr 17, 2:22 PM
F15490221: D16712.id40246.diff
Fri, Apr 11, 3:20 PM
F15483410: D16712.diff
Wed, Apr 9, 12:06 PM
F15482394: D16712.id40247.diff
Wed, Apr 9, 5:11 AM
F15481017: D16712.diff
Tue, Apr 8, 5:46 PM
F15479475: D16712.id.diff
Tue, Apr 8, 7:33 AM
F15477848: D16712.diff
Mon, Apr 7, 6:17 PM
F15452672: D16712.diff
Sat, Mar 29, 6:36 AM
View All Files
Subscribers
Korvin
Tokens
"Haypence" token, awarded by epriestley.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPb1449fab63ff: Fixed undefined variable error in call from ConduitIntListParameterType
Summary

$strict parameter was missing in $this->parseIntValue(...) call.

Test Plan
$ curl http://$PHABRICATOR_HOST/api/maniphest.search -d api.token=$CONDUIT_TOKEN -d constraints[priorities][0]=90 -d limit=1
# OK

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gd updated this revision to Diff 40246.Oct 17 2016, 12:16 PM
gd retitled this revision from to Fixed undefined variable error in call from ConduitIntListParameterType.
gd updated this object.
gd edited the test plan for this revision. (Show Details)
gd added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 17 2016, 12:16 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Oct 17 2016, 12:35 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 17 2016, 12:35 PM
Closed by commit rPb1449fab63ff: Fixed undefined variable error in call from ConduitIntListParameterType (authored by gd, committed by gd). · Explain WhyOct 17 2016, 12:38 PM
This revision was automatically updated to reflect the committed changes.
epriestley awarded a token.Oct 17 2016, 12:38 PM

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
parametertype/
6 lines

Diff 40247

View Options

src/applications/conduit/parametertype/ConduitIntListParameterType.php

Loading...
Phabricator · Built by Phacility