Paths

Table of Contentst

Differential D16712

Fixed undefined variable error in call from ConduitIntListParameterType
ClosedPublic
Actions

Authored by gd on Oct 17 2016, 12:16 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPb1449fab63ff: Fixed undefined variable error in call from ConduitIntListParameterType

Summary

$strict parameter was missing in $this->parseIntValue(...) call.

Test Plan

$ curl http://$PHABRICATOR_HOST/api/maniphest.search -d api.token=$CONDUIT_TOKEN -d constraints[priorities][0]=90 -d limit=1
# OK

Diff Detail

Repository

rP Phabricator

Branch

conduit-int-list-fix

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14139
Build 18363: arc lint + arc unit

Event Timeline

gd updated this revision to Diff 40246.Oct 17 2016, 12:16 PM

gd retitled this revision from to Fixed undefined variable error in call from ConduitIntListParameterType.

gd updated this object.

gd edited the test plan for this revision. (Show Details)

gd added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 17 2016, 12:16 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Oct 17 2016, 12:35 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 17 2016, 12:35 PM

Closed by commit rPb1449fab63ff: Fixed undefined variable error in call from ConduitIntListParameterType (authored by gd, committed by gd). · Explain WhyOct 17 2016, 12:38 PM

This revision was automatically updated to reflect the committed changes.

epriestley awarded a token.Oct 17 2016, 12:38 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

parametertype/

ConduitIntListParameterType.php

6 lines

Diff 40246

View Options

src/applications/conduit/parametertype/ConduitIntListParameterType.php

Fixed undefined variable error in call from ConduitIntListParameterTypeClosedPublicActions