Page MenuHomePhabricator
Differential D16698

Fix some libphutil Calendar document bugs
ClosedPublic
Actions

Authored by epriestley on Oct 12 2016, 8:43 PM.
Tags
None
Referenced Files
F14026131: D16698.id40198.diff
Thu, Nov 7, 11:46 PM
F14013529: D16698.id40198.diff
Sat, Nov 2, 7:34 AM
F14004615: D16698.id40198.diff
Sat, Oct 26, 11:48 PM
F13977205: D16698.diff
Fri, Oct 18, 5:37 PM
F13972776: D16698.id40198.diff
Thu, Oct 17, 9:12 PM
Unknown Object (File)
Sun, Oct 13, 7:54 PM
Unknown Object (File)
Sep 16 2024, 8:32 PM
Unknown Object (File)
Sep 15 2024, 10:18 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPHU72a4c65ec945: Fix some libphutil Calendar document bugs
Summary

Ref T10747.

  • Default to UTC if a datetime has no explicit timezone.
  • Fix a bug with escape detection that could incorrectly trigger for escaped commas.
  • Remove some unused properties (now properites of the RRULE itself).
Test Plan

See next diff.

Diff Detail

Repository
rPHU libphutil
Branch
cal4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14089
Build 18281: Run Core Tests
Build 18280: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40196.Oct 12 2016, 8:43 PM
epriestley retitled this revision from to Fix some libphutil Calendar document bugs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 12 2016, 8:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 12 2016, 8:59 PM
Closed by commit rPHU72a4c65ec945: Fix some libphutil Calendar document bugs (authored by epriestley, committed by epriestley). · Explain WhyOct 12 2016, 10:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
data/
2 lines
18 lines
ics/
1 line

Diff 40196

View Options

src/parser/calendar/data/PhutilCalendarDateTime.php

Loading...
View Options

src/parser/calendar/data/PhutilCalendarEventNode.php

Loading...
View Options

src/parser/calendar/ics/PhutilICSParser.php

Loading...
Phabricator · Built by Phacility