This moves room pictures out of the dialog and into it's own PictureController. Also adds a standard image (and removes the "last person to chat" picture (though we could add that back. My plan is though that direct messages use auto use the other person's photo, after we have editengine and room pictures will have a plain, replaceable image.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T11730: Remove image crop from Conpherence
- Commits
- rPd68c444ffada: Convert Conpherence to use normal picture setting flows
Set a new room picture, remove a picture. Run migration, see old images properly set with new image.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- room-picture (branched from master)
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 14015 Build 18174: Run Core Tests Build 18173: arc lint + arc unit
Time | Test | |
---|---|---|
470 ms | PhabricatorCelerityTestCase::Unknown Unit Message (" |