Differential D16664

Migrate Calendar away from stored-epoch fields
ClosedPublic
Actions

Authored by epriestley on Oct 4 2016, 7:50 PM.

Tags

None

Referenced Files

	F13168301: D16664.diff
	Tue, May 7, 7:38 AM

	Unknown Object (File)
	Fri, May 3, 7:17 AM

	Unknown Object (File)
	Wed, May 1, 4:30 PM

	Unknown Object (File)
	Thu, Apr 25, 1:25 AM

	Unknown Object (File)
	Fri, Apr 19, 5:25 PM

	Unknown Object (File)
	Apr 7 2024, 10:51 AM

	Unknown Object (File)
	Apr 5 2024, 6:52 AM

	Unknown Object (File)
	Mar 22 2024, 8:50 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPd3fc1800f86a: Migrate Calendar away from stored-epoch fields

Summary

Ref T10747. This deprecates "dateFrom", "dateTo", "allDayDateFrom", "allDayDateTo", and "recurrenceEndDate".

They are replaced with "utc*Epoch" fields (for querying) and CalendarDateTime objects (for start, end, until). These objects can represent the full range of dates and times expressible in ICS format, allowing us to import a wider range of ICS events.

Test Plan

Ran migrations, viewed/edited Calendar, didn't catch anything catastrophcially broken.

This likely needs some followups, I'll keep it local for a bit until I'm confident I didn't break anything too catastrophically. I'm retaining the old data for now so we can likely fix things if it turns out there is some sort of issue.

Diff Detail

Repository

Branch

cal7

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/calendar/storage/PhabricatorCalendarEvent.php:49	XHP16	TODO Comment
Advice	src/applications/calendar/storage/PhabricatorCalendarEvent.php:362	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 14007
Build 18160: Run Core Tests
Build 18159: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40117.Oct 4 2016, 7:50 PM

epriestley retitled this revision from to Migrate Calendar away from stored-epoch fields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 4 2016, 8:05 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 4 2016, 8:05 PM

epriestley mentioned this in T11326: Improve Calendar v1 Design/UI/UX.Oct 5 2016, 5:25 PM

Closed by commit rPd3fc1800f86a: Migrate Calendar away from stored-epoch fields (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 10:56 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11735: Upgrading: Calendar Storage Migrations.Oct 6 2016, 11:05 AM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160715.event.03.allday.php

51 lines

20161004.cal.01.noepoch.php

125 lines

src/

applications/

calendar/

query/

PhabricatorCalendarEventQuery.php

4 lines

storage/

PhabricatorCalendarEvent.php

109 lines

xaction/

PhabricatorCalendarEventEndDateTransaction.php

10 lines

PhabricatorCalendarEventStartDateTransaction.php

10 lines

Diff 40117

resources/sql/autopatches/20160715.event.03.allday.php

Loading...

resources/sql/autopatches/20161004.cal.01.noepoch.php

Loading...

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php

Loading...

src/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php

Loading...