Page MenuHomePhabricator

Remove "viewerDateFrom" / "viewerDateTo" in favor of CalendarDateTime methods
ClosedPublic

Authored by epriestley on Oct 4 2016, 4:55 PM.
Tags
None
Referenced Files
F15509478: D16662.id40115.diff
Wed, Apr 16, 12:38 PM
F15507261: D16662.diff
Tue, Apr 15, 5:56 PM
F15498584: D16662.id40146.diff
Sun, Apr 13, 1:25 PM
F15492891: D16662.id.diff
Sat, Apr 12, 7:26 PM
F15492765: D16662.id40115.diff
Sat, Apr 12, 6:02 PM
F15492678: D16662.id40114.diff
Sat, Apr 12, 5:06 PM
F15490189: D16662.diff
Fri, Apr 11, 3:04 PM
F15475747: D16662.diff
Sun, Apr 6, 11:18 PM
Subscribers
None

Details

Summary

Ref T10747. The CalendarDateTime object now carries the viewer timezone as part of its state, so we don't need to have separate accessors.

Test Plan
  • Viewed events, checked that crumbs render properly.
  • Edited events.
  • Created new events.
  • Viewed calendar.
  • Viewed event detail pages.
  • Viewed profile mini-calendar.

Diff Detail

Repository
rP Phabricator
Branch
cal5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14004
Build 18154: Run Core Tests
Build 18153: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40115.
epriestley retitled this revision from to Remove "viewerDateFrom" / "viewerDateTo" in favor of CalendarDateTime methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Minor spacing fixes.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 4 2016, 5:28 PM
This revision was automatically updated to reflect the committed changes.