Page MenuHomePhabricator

Remove "viewerDateFrom" / "viewerDateTo" in favor of CalendarDateTime methods
ClosedPublic

Authored by epriestley on Oct 4 2016, 4:55 PM.
Tags
None
Referenced Files
F17954367: D16662.id40146.diff
Fri, Aug 1, 4:00 AM
F17953597: D16662.id40115.diff
Fri, Aug 1, 3:13 AM
F17948244: D16662.id40114.diff
Thu, Jul 31, 8:26 PM
F17937821: D16662.id.diff
Thu, Jul 31, 1:39 AM
F17919685: D16662.diff
Wed, Jul 30, 2:48 AM
F17907262: D16662.id40146.diff
Tue, Jul 29, 1:13 PM
Unknown Object (File)
Jun 28 2025, 9:04 PM
Unknown Object (File)
Jun 18 2025, 7:29 PM
Subscribers
None

Details

Summary

Ref T10747. The CalendarDateTime object now carries the viewer timezone as part of its state, so we don't need to have separate accessors.

Test Plan
  • Viewed events, checked that crumbs render properly.
  • Edited events.
  • Created new events.
  • Viewed calendar.
  • Viewed event detail pages.
  • Viewed profile mini-calendar.

Diff Detail

Repository
rP Phabricator
Branch
cal5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14005
Build 18156: Run Core Tests
Build 18155: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40115.
epriestley retitled this revision from to Remove "viewerDateFrom" / "viewerDateTo" in favor of CalendarDateTime methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Minor spacing fixes.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 4 2016, 5:28 PM
This revision was automatically updated to reflect the committed changes.