Page MenuHomePhabricator

Remove "viewerDateFrom" / "viewerDateTo" in favor of CalendarDateTime methods
ClosedPublic

Authored by epriestley on Oct 4 2016, 4:55 PM.
Tags
None
Referenced Files
F18905147: D16662.id40114.diff
Sat, Nov 8, 1:04 PM
F18905145: D16662.id40115.diff
Sat, Nov 8, 1:04 PM
F18870257: D16662.diff
Tue, Nov 4, 4:13 PM
F18826801: D16662.id.diff
Oct 24 2025, 5:47 AM
F18783095: D16662.id40115.diff
Oct 13 2025, 3:38 AM
F18760085: D16662.id40114.diff
Oct 6 2025, 7:57 AM
F18652671: D16662.diff
Sep 21 2025, 8:57 AM
F18617016: D16662.id.diff
Sep 14 2025, 7:52 PM
Subscribers
None

Details

Summary

Ref T10747. The CalendarDateTime object now carries the viewer timezone as part of its state, so we don't need to have separate accessors.

Test Plan
  • Viewed events, checked that crumbs render properly.
  • Edited events.
  • Created new events.
  • Viewed calendar.
  • Viewed event detail pages.
  • Viewed profile mini-calendar.

Diff Detail

Repository
rP Phabricator
Branch
cal5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14005
Build 18156: Run Core Tests
Build 18155: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40115.
epriestley retitled this revision from to Remove "viewerDateFrom" / "viewerDateTo" in favor of CalendarDateTime methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Minor spacing fixes.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 4 2016, 5:28 PM
This revision was automatically updated to reflect the committed changes.