Details

Reviewers

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU5a9e3ef1bfe0: Allow DateTime objects to be serialized and deserialized

Summary

Ref T10747. I have to move CalendarEvents to use these for everything because ICS files can have events which we can't represent with an epoch (e.g., floating "4PM" events).

Also improve some timezone/floating logic when rendering to ISO8601.

Test Plan

arc unit; see next change.

Diff Detail

Repository

rPHU libphutil

Branch

cal3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14001
Build 18148: Run Core Tests
Build 18147: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40088.Oct 3 2016, 4:57 PM

epriestley retitled this revision from to Allow DateTime objects to be serialized and deserialized.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 3 2016, 5:39 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 3 2016, 5:39 PM

Also serialize/deserialize Durations.
Add a newRelativeDateTime() convenience method.

Fix a bug where conversion to absolute datetime could lose timezone information.

Also expose newPHPDateTime() as public, mostly for format().

Closed by commit rPHU5a9e3ef1bfe0: Allow DateTime objects to be serialized and deserialized (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 10:39 AM

This revision was automatically updated to reflect the committed changes.

Allow DateTime objects to be serialized and deserialized
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 40111

src/parser/calendar/data/PhutilCalendarAbsoluteDateTime.php

src/parser/calendar/data/PhutilCalendarDateTime.php

src/parser/calendar/data/PhutilCalendarDuration.php

src/parser/calendar/data/PhutilCalendarProxyDateTime.php

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

src/parser/calendar/ics/PhutilICSParser.php

Allow DateTime objects to be serialized and deserializedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40111

src/parser/calendar/data/PhutilCalendarAbsoluteDateTime.php

src/parser/calendar/data/PhutilCalendarDateTime.php

src/parser/calendar/data/PhutilCalendarDuration.php

src/parser/calendar/data/PhutilCalendarProxyDateTime.php

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

src/parser/calendar/ics/PhutilICSParser.php

Allow DateTime objects to be serialized and deserialized
ClosedPublic
Actions

Revision Contents
Changeset List