Differential D16636

When a file is stored as chunks, show "Format: Chunks" instead of "Format: Raw"
ClosedPublic
Actions

Authored by epriestley on Sep 29 2016, 10:42 PM.

Details

Reviewers

chad

Maniphest Tasks

T11712: file chunks not encrypted when enabling file encryption

Commits

rPd5925ffc5779: When a file is stored as chunks, show "Format: Chunks" instead of "Format: Raw"

Summary

Fixes T11712. This is somewhat misleading with encryption enabled.

Test Plan

Viewed chunked and unchunked files.

Diff Detail

Repository

rP Phabricator

Branch

rawdata

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13933
Build 18046: Run Core Tests
Build 18045: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40044.Sep 29 2016, 10:42 PM

epriestley retitled this revision from to When a file is stored as chunks, show "Format: Chunks" instead of "Format: Raw".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11712: file chunks not encrypted when enabling file encryption.

chad accepted this revision.Sep 29 2016, 10:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 29 2016, 10:43 PM

epriestley mentioned this in T11712: file chunks not encrypted when enabling file encryption.Sep 29 2016, 10:46 PM

Closed by commit rPd5925ffc5779: When a file is stored as chunks, show "Format: Chunks" instead of "Format: Raw" (authored by epriestley, committed by epriestley). · Explain WhySep 29 2016, 10:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

controller/

PhabricatorFileInfoController.php

36 lines

Diff 40044

View Options

src/applications/files/controller/PhabricatorFileInfoController.php

When a file is stored as chunks, show "Format: Chunks" instead of "Format: Raw"ClosedPublicActions