Differential D16630

Support BYSETPOS for RRULE events with FREQ=MINUTELY
ClosedPublic
Actions

Authored by epriestley on Sep 29 2016, 6:57 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU1024f03f68e8: Support BYSETPOS for RRULE events with FREQ=MINUTELY

Summary

Ref T10747. (Most of the MINUTELY tests in the source I'm cribbing from aren't too interesting so I omitted a chunk of them.)

Test Plan

Unit tests now pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13926
Build 18033: Run Core Tests
Build 18032: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40037.Sep 29 2016, 6:57 PM

epriestley retitled this revision from to Support BYSETPOS for RRULE events with FREQ=MINUTELY.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 29 2016, 8:18 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 29 2016, 8:18 PM

Closed by commit rPHU1024f03f68e8: Support BYSETPOS for RRULE events with FREQ=MINUTELY (authored by epriestley, committed by epriestley). · Explain WhySep 29 2016, 11:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

15 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

52 lines

Diff 40037

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Support BYSETPOS for RRULE events with FREQ=MINUTELYClosedPublicActions