Differential D16629

Support BYSETPOS for RRULE events with FREQ=HOURLY
ClosedPublic
Actions

Authored by epriestley on Sep 29 2016, 6:39 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU49f472ab8578: Support BYSETPOS for RRULE events with FREQ=HOURLY

Summary

Ref T10747. Most of these tests already passed; implement BYSETPOS logic for FREQ=HOURLY.

Test Plan

Unit tests now pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13925
Build 18031: Run Core Tests
Build 18030: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40036.Sep 29 2016, 6:39 PM

epriestley retitled this revision from to Support BYSETPOS for RRULE events with FREQ=HOURLY.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 29 2016, 7:46 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 29 2016, 7:46 PM

Closed by commit rPHU49f472ab8578: Support BYSETPOS for RRULE events with FREQ=HOURLY (authored by epriestley, committed by epriestley). · Explain WhySep 29 2016, 11:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

44 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

125 lines

Diff 40036

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Support BYSETPOS for RRULE events with FREQ=HOURLYClosedPublicActions