Page MenuHomePhabricator
Differential D16609

Fix two RRULE bugs with YEARDAY
ClosedPublic
Actions

Authored by epriestley on Sep 27 2016, 11:30 PM.
Tags
None
Referenced Files
F13183037: D16609.id.diff
Fri, May 10, 6:23 AM
F13182762: D16609.id39999.diff
Fri, May 10, 2:33 AM
Unknown Object (File)
Sat, May 4, 6:28 PM
Unknown Object (File)
Sun, Apr 28, 11:51 AM
Unknown Object (File)
Fri, Apr 26, 2:30 AM
Unknown Object (File)
Fri, Apr 26, 2:30 AM
Unknown Object (File)
Fri, Apr 26, 2:30 AM
Unknown Object (File)
Wed, Apr 24, 11:14 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPHUa84b6f73a7dd: Fix two RRULE bugs with YEARDAY
Summary

Ref T10747. One bug was a simple typo. Other bug is that we need to expand months if YEARDAY is present.

Test Plan

Unit tests now pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39982.Sep 27 2016, 11:30 PM
epriestley retitled this revision from to Fix two RRULE bugs with YEARDAY.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Sep 28 2016, 12:07 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 12:07 AM
Closed by commit rPHUa84b6f73a7dd: Fix two RRULE bugs with YEARDAY (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
data/
19 lines
__tests__/
37 lines

Diff 39999

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

Loading...
View Options

src/parser/calendar/data/__tests__/PhutilCalendarRecurrenceRuleTestCase.php

Loading...
Phabricator · Built by Phacility