Differential D16609

Fix two RRULE bugs with YEARDAY
ClosedPublic
Actions

Authored by epriestley on Sep 27 2016, 11:30 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHUa84b6f73a7dd: Fix two RRULE bugs with YEARDAY

Summary

Ref T10747. One bug was a simple typo. Other bug is that we need to expand months if YEARDAY is present.

Test Plan

Unit tests now pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13871
Build 17950: Run Core Tests
Build 17949: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39982.Sep 27 2016, 11:30 PM

epriestley retitled this revision from to Fix two RRULE bugs with YEARDAY.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 28 2016, 12:07 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 28 2016, 12:07 AM

Closed by commit rPHUa84b6f73a7dd: Fix two RRULE bugs with YEARDAY (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

19 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

37 lines

Diff 39982

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Fix two RRULE bugs with YEARDAYClosedPublicActions