Paths

Table of Contentst

Differential D16607

Fix a remaining `cursorYear` instead of `stateYear`
ClosedPublic
Actions

Authored by epriestley on Sep 27 2016, 10:52 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU03ca6a391f8e: Fix a remaining `cursorYear` instead of `stateYear`

Summary

Ref T10747. Last test failed because we were looking at weekdays in the wrong year. Root issue is bad cursorYear, other changes are just cleanup/debugging.

Test Plan

Unit tests now pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13868
Build 17944: Run Core Tests
Build 17943: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39979.Sep 27 2016, 10:52 PM

epriestley retitled this revision from to Fix a remaining `cursorYear` instead of `stateYear`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 27 2016, 11:19 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 27 2016, 11:19 PM

Closed by commit rPHU03ca6a391f8e: Fix a remaining `cursorYear` instead of `stateYear` (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

5 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

24 lines

Diff 39979

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Fix a remaining `cursorYear` instead of `stateYear`ClosedPublicActions